[PATCH] D146854: [Symbolizer] Add flag to dump symbolizer markup context JSON.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

A few minor points from me that I spotted whilst skimming over this due to my herald rule pinging me. I am not familiar enough with the markup stuff to be able to review that.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-dump-context.test:5-6
+RUN:   --implicit-check-not {{.}}
+RUN: not llvm-symbolizer --dump-context
+RUN: not llvm-symbolizer --no-dump-context
+
----------------
You should check that the error message is the expected error message here. Otherwise, these could be failing for an unrelated reason and you wouldn't notice.


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-dump-context.test:9
+CHECK: [
+CHECK:   {
+CHECK:     "modules": [
----------------
CHECK-NEXT (or CHECK-SAME) here and below?


================
Comment at: llvm/tools/llvm-symbolizer/Opts.td:34
 defm demangle : B<"demangle", "Demangle function names", "Don't demangle function names">;
+defm dump_context : B<"dump-context", "Only dump symbolizer markup context as JSON.", "Don't dump markup context.">;
 def filter_markup : Flag<["--"], "filter-markup">, HelpText<"Filter symbolizer markup from stdin.">;
----------------
Nit: for consistency with other options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146854/new/

https://reviews.llvm.org/D146854