[PATCH] D146876: [ThinLTO] Only import for non-prevailing interposable global variables

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 25 11:04:43 PDT 2023


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with one minor test suggestion



================
Comment at: llvm/test/ThinLTO/X86/prevailing_weak_globals_import.ll:15
+;; It should also be defined in the corresponding object file
+; NM: def
+
----------------
I think this will also match against the def of the longer "ret_av_ext_def" symbol. Is there a way to make it a bit tighter, e.g. something like:
; NM: W def


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146876/new/

https://reviews.llvm.org/D146876



More information about the llvm-commits mailing list