[PATCH] D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.

LGTM with test nit



================
Comment at: llvm/test/CodeGen/AMDGPU/opencl-printf-pipeline.ll:12
+; CHECK-LABEL: define void @foo
+; CHECK-NOT: call i32{{.*}}@printf
+define void @foo() {
----------------
This will be a really fragile negative check, just use generated checks for the output


================
Comment at: llvm/test/CodeGen/AMDGPU/opencl-printf-pipeline.ll:14
+define void @foo() {
+  %call = call i32 (ptr addrspace(4), ...) @printf(ptr addrspace(4) noundef @.str)
+  ret void
----------------
Don't think you need the (ptr addrspace(4), ...) here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146720/new/

https://reviews.llvm.org/D146720