[PATCH] D123515: [RISCV] Support '.option arch' directive

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 08:29:25 PDT 2023


luismarques added inline comments.


================
Comment at: llvm/test/MC/RISCV/option-invalid.s:31-32
+
+# CHECK: :[[#@LINE+1]]:16: error: Don't specify version number, extensions don't rely on version numbers
+.option arch, +c2p0
+
----------------
The error should be that we don't (yet) support version numbers here, not that "extensions don't rely on version numbers", since the spec for `.option arch` does include explicit support for version numbers. Or just add such support to this patch, instead of being a follow-up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515



More information about the llvm-commits mailing list