[PATCH] D145301: Add more efficient vector bitcast for AArch64

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/vec-combine-compare-and-store.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=aarch64-apple-darwin -mattr=+neon -verify-machineinstrs < %s | FileCheck %s
----------------
Please can you re-run the update_llc_test_checks.py script for the new version and let it generate the CHECK lines for the new test?

Also, it would be good if you can pre-commit these tests before this patch, so that in the diff here we can see the changes in generated code? That helps the reviewers to see what effect your new DAG combines have.


================
Comment at: llvm/test/CodeGen/AArch64/vec-combine-compare-to-bitmask.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=aarch64-apple-darwin -mattr=+neon -verify-machineinstrs < %s | FileCheck %s
----------------
Please can you re-run the update_llc_test_checks.py script for the new version and let it generate the CHECK lines for the new test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145301/new/

https://reviews.llvm.org/D145301