[PATCH] D142879: [RISCV] Emit relocation for uleb128

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 01:12:34 PDT 2023


kito-cheng marked 5 inline comments as done.
kito-cheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:283
+
+  int64_t IntValue;
+  if (!Value->evaluateAsAbsolute(IntValue, getAssemblerPtr())) {
----------------
jrtc27 wrote:
> encodeULEB128 takes a uint64_t
`evaluateAsAbsolute` take `int64_t &`...added a check to make sure that won't overflow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142879/new/

https://reviews.llvm.org/D142879



More information about the llvm-commits mailing list