[PATCH] D146694: [NFC] Fix auto usage to avoid copies

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 00:11:57 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20966
         bool Merged = true;
-        for (auto I : enumerate(Ops)) {
+        for (auto const& I : enumerate(Ops)) {
           SDValue &Op = I.value();
----------------
Doesn't the deference operator for enumerate return by value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146694/new/

https://reviews.llvm.org/D146694



More information about the llvm-commits mailing list