[PATCH] D146683: [DAG Combine] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 20:17:28 PDT 2023


xiangzhangllvm created this revision.
xiangzhangllvm added reviewers: RKSimon, craig.topper, pengfei, LuoYuanke.
Herald added subscribers: ecnelises, hiraditya.
Herald added a project: All.
xiangzhangllvm requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

tryToFoldExtendSelectLoad can be called in DAG combine2 which has already finish legalization
So we should conservatively check the Operation Action for new VSELECT.


https://reviews.llvm.org/D146683

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/test/CodeGen/X86/select-ext.ll
  llvm/test/CodeGen/X86/vselect-post-combine.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146683.507579.patch
Type: text/x-patch
Size: 5618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230323/5cca5d5f/attachment.bin>


More information about the llvm-commits mailing list