[PATCH] D146641: [JITLink] Introduce target flags for Symbol and prepare ObjectLinkingLayer to account for them

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 09:53:47 PDT 2023


sgraenitz added a comment.

This is a rather quick sketch that aims to be as non-intrusive as possible. I will add the ThumbSymbol handling in D144083 <https://reviews.llvm.org/D144083>.



================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:675
   size_t Size = 0;
+  TargetFlagsType TargetFlags;
 };
----------------
Conceptually, this should be generic and allow targets to store a variety of flags, but for the time being I guess `ThumbSymbol` will be the only flag we have upstream.

Anyway, non of these data structures are serialized, so can change it any time. I could take one more bit away from Offset to reduce memory pressure. (Or Two?) What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146641/new/

https://reviews.llvm.org/D146641



More information about the llvm-commits mailing list