[PATCH] D139024: [Backend][AsmPrinter][CFI] Generate unwind table entries in .eh_frame when the uwtable attribute is present.

Juan Manuel Martinez CaamaƱo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 08:35:43 PDT 2023


jmmartinez added reviewers: respindola, rengolin.
jmmartinez added subscribers: respindola, rengolin.
jmmartinez added a comment.

@respindola & @rengolin, I've added you as reviewers since I've read your discussion from 2014 about Unwind behaviour in Clang/LLVM <https://groups.google.com/g/llvm-dev/c/yxSFS-TH3aU?pli=1> and I've though this issue is related.

In this patch I propose to generate entries using DwarfCFI in the .eh_frame region for functions with the `uwtable` attribute; when the target's EH type is either None or DwarfCFI.
I have the feeling that this last condition could be relaxed and these entries could be generated for all targets that support DwarfCFI  (I ran some quick tests on my development setup and it didn't break any test).

What's my motivation for this? In my particular case, to support unwinding with the sanitizers on AMDGPU in the future.

Do you have some advice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139024/new/

https://reviews.llvm.org/D139024



More information about the llvm-commits mailing list