[PATCH] D146621: [sanitizer][win] Change cmdline check to allow double backslashs

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 03:45:26 PDT 2023


mstorsjo added reviewers: tejohnson, mcgov.
mstorsjo added a subscriber: llvm-commits.
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

Maybe adjust the commit message a little,

> multiple consecutive backslashes does not have any special effect, unless they are immediately followed by a double quote.

I would say backslashes in general, regardless of whether they're single or multiple, don't have any special effect unless followed by a double quote.

Other than that, I think this change is fine (I presume you tested running in such a setup); I added a couple others as reviewers as well, so maybe wait for a day or two if they want to chime in on the matter too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146621/new/

https://reviews.llvm.org/D146621



More information about the llvm-commits mailing list