[PATCH] D146260: Make code size metric names independent of platform

Azharuddin Mohammed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 10:45:50 PDT 2023


azharudd added subscribers: jpaquette, azharudd.
azharudd added a comment.

@jpaquette, what do you think?



================
Comment at: litsupport/modules/codesize.py:42
                     logging.info("Ignoring malformed output line: %s", line)
 
     return metrics
----------------
I was just thinking maybe, as a good measure, we can assert here that only one of `size.__text` or `size..text` is present in `metrics`.

```
assert not ('size.__text' in metrics and 'size..text' in metrics), "Both 'size.__text' and 'size..text' present in metrics. Only one of them should exist."
```


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146260/new/

https://reviews.llvm.org/D146260



More information about the llvm-commits mailing list