[PATCH] D144732: [Assignment Tracking] Elide a map copy in some cases

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 06:16:27 PDT 2023


Orlando updated this revision to Diff 505068.
Orlando marked an inline comment as done.
Orlando added a comment.

It actually looks like this is now more important with D145558 <https://reviews.llvm.org/D145558> applied (around 0.24% difference). Here is the impact when this patch is reverted: http://llvm-compile-time-tracker.com/compare.php?from=baec5155d5e0c5d8cc0a2f51bd7fa14f785a0093&to=68d93a1c2d58990d7cd96f0b826b944fcc7d86f3&stat=instructions

+ Use ArrayRef.drop_front to get the preds vector "tail" 
+ Reduce clutter of insertion code 
+ Address nits


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144732/new/

https://reviews.llvm.org/D144732

Files:
  llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144732.505068.patch
Type: text/x-patch
Size: 4473 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230314/783c138a/attachment.bin>


More information about the llvm-commits mailing list