[PATCH] D145812: [ConstraintElimination] UB reproducer for D145677

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 10:17:09 PST 2023


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/ConstraintElimination/shl.ll:1279
+
+define i1 @shl_overflow_4() {
+; CHECK-LABEL: @shl_overflow_4(
----------------
Maybe just name this `shl_55` or something, as this shouldn't overflow. Also might be good to replace `0` with `1` here, as `uge 0` is trivially true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145812/new/

https://reviews.llvm.org/D145812



More information about the llvm-commits mailing list