[PATCH] D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 14:19:24 PST 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1548
+  std::array PossibleAlignments{4, 8};
+  for (unsigned Align : PossibleAlignments) {
+    uint64_t AlignedOffset = alignTo(Offset, Align);
----------------
Certain compilers => ARM C/C++ Compiler.

Be more specific when available information is useful. It helps decide whether the code is a workaround and when it can be removed.

You can adjust the previous comment or this comment to say that we are testing 4 and 8 as possible alignments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143513/new/

https://reviews.llvm.org/D143513



More information about the llvm-commits mailing list