[PATCH] D145325: [docs][NewPM] fix typos in new pass manager docs

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 09:18:14 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a5d4eb775c6: [docs][NewPM] fix typos in new pass manager docs (authored by AlexM, committed by aeubanks).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145325/new/

https://reviews.llvm.org/D145325

Files:
  llvm/docs/NewPassManager.rst


Index: llvm/docs/NewPassManager.rst
===================================================================
--- llvm/docs/NewPassManager.rst
+++ llvm/docs/NewPassManager.rst
@@ -92,9 +92,9 @@
   MPM.addPass(createModuleToFunctionPassAdaptor(FunctionFooPass()));
 
   // loop -> function -> cgscc -> module
-  MPM.addPass(createModuleToCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(createFunctionToLoopPassAdaptor(LoopFooPass()))));
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(createFunctionToLoopPassAdaptor(LoopFooPass()))));
   // function -> cgscc -> module
-  MPM.addPass(createModuleToCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(FunctionFooPass())));
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(createCGSCCToFunctionPassAdaptor(FunctionFooPass())));
 
 
 A pass manager of a specific IR unit is also a pass of that kind. For
@@ -386,7 +386,7 @@
 .. code-block:: c++
 
   bool FooAnalysisResult::invalidate(Function &F, const PreservedAnalyses &PA,
-                                     FunctionAnalysisManager::Invalidator &) {
+                                     FunctionAnalysisManager::Invalidator &Inv) {
     auto PAC = PA.getChecker<FooAnalysis>();
     if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Function>>())
       return true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145325.502687.patch
Type: text/x-patch
Size: 1318 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230306/d1ca48c2/attachment.bin>


More information about the llvm-commits mailing list