[PATCH] D144955: Fix SGPR + offset Scratch offset folding

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 05:02:50 PST 2023


arsenm added a comment.

Missing corresponding globalisel change?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1766
+    // 32-bit add instruction, otherwise use sgpr base(unsigned) + offset.
+    KnownBits SAddrKnown = CurDAG->computeKnownBits(Addr.getOperand(0));
+    if (SAddrKnown.isNonNegative()) {
----------------
SignBitIsZero?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144955/new/

https://reviews.llvm.org/D144955



More information about the llvm-commits mailing list