[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 13:12:00 PST 2023


aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IPO.cpp:33
 
 void LLVMInitializeIPO(LLVMPassRegistryRef R) {
   initializeIPO(*unwrap(R));
----------------
nikic wrote:
> aeubanks wrote:
> > all of these initialize functions should also be deleted (everything in Initialization.h)
> Isn't it necessary to still call initialization functions for passes used in the codegen pipeline?
`LLVMInitializeIPO` (and others) are part of the C API, which as mentioned in the description can't be used for the codegen pipeline. We'll still keep around `llvm::initializeIPO` above. Actually we should just delete `LLVMPassRegistryRef` altogether


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144970/new/

https://reviews.llvm.org/D144970



More information about the llvm-commits mailing list