[PATCH] D144720: [AVR] Fix incorrect flags of livein registers when spilling them

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRFrameLowering.cpp:264
+    // add it to livein list.
+    for (const auto &livein : MBB.liveins())
+      if (TRI->getRegSizeInBits(livein.PhysReg, MF.getRegInfo()) == 16) {
----------------
`livein` should be capital.


================
Comment at: llvm/lib/Target/AVR/AVRFrameLowering.cpp:268
+        STI.getRegisterInfo()->splitReg(livein.PhysReg, LoSub, HiSub);
+        if (Reg == HiSub || Reg == LoSub) {
+          MBB.addLiveIn(Reg);
----------------
Could we use `isSubRegister` to check if it is a subreg?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144720/new/

https://reviews.llvm.org/D144720