[PATCH] D144466: [WebAssembly] Revert result operand ordering for pmin/pmax

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 08:28:15 PST 2023


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Yes, pmin is `rhs < lhs ? rhs : lhs` and pmax is `lhs < rhs ? rhs : lhs`, so if either input is NaN, the result for either operation should be `lhs`. IIUC, before this patch NaN inputs would result in `rhs` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144466/new/

https://reviews.llvm.org/D144466



More information about the llvm-commits mailing list