[PATCH] D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type.

Joshua Cranmer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 11:31:19 PST 2023


jcranmer-intel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1703-1705
+  // The code below doesn't work on scalable target types.
+  if (TrueVal->getType()->isScalableTargetExtTy())
+    return nullptr;
----------------
A better fix here, I think, is to add a test for the block below so that it only applies to integer or integer vector types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136861/new/

https://reviews.llvm.org/D136861



More information about the llvm-commits mailing list