[PATCH] D143898: [CodeGenPrepare] Fold addressing mode into calls
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Feb 13 10:30:17 PST 2023
    
    
  
efriedma added a comment.
If I'm understanding correctly, the point is that we don't want to block folding if an address computation has multiple uses, where only some are foldable?
Expressing this in terms of "folding into a call" seems confusing and unnecessary; we should just change the logic to allow sinking if we can fold some, but not all, the uses.  (Maybe including some sort analysis of whether folding increases the number of times we perform the address computation at runtime.)
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143898/new/
https://reviews.llvm.org/D143898
    
    
More information about the llvm-commits
mailing list