[PATCH] D142711: AArch64: count call stack when working out if scavenging is needed

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:3084
+    if (FixedOff > CalleeStackUsed) CalleeStackUsed = FixedOff;
+  }
+
----------------
efriedma wrote:
> To be clear, this is looking at arguments passed on the stack by the caller of this function definition?  If we use a frame index to access them, and we don't have a frame pointer, they need to count towards the stack limit, sure.
> 
> Referring to this as the "callee's stack" is a bit confusing.
It is confusing. It's both callee and caller stack space (i.e. used only for args, but might be incoming or outgoing). Regardless, I did word that badly. I'll try to improve it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142711/new/

https://reviews.llvm.org/D142711