[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D142443#4102519 <https://reviews.llvm.org/D142443#4102519>, @Hahnfeld wrote:

> In D142443#4102513 <https://reviews.llvm.org/D142443#4102513>, @spatel wrote:
>
>> The test seems to be crashing on macOS with or without the code change:
>> "LLVM ERROR: MachO doesn't support COMDATs, 'f' cannot be lowered."
>
> Hm right... If you are on macOS, could you test if `XFAIL: target={{.*}}-darwin{{.*}}` correctly excludes the test?

Still crashing after I add that line - let me know if I'm missing anything:
diff --git a/llvm/test/ExecutionEngine/Orc/weak-comdat.ll b/llvm/test/ExecutionEngine/Orc/weak-comdat.ll
index 8cedd57ef922..7195f5a2b00e 100644

- a/llvm/test/ExecutionEngine/Orc/weak-comdat.ll

+++ b/llvm/test/ExecutionEngine/Orc/weak-comdat.ll
@@ -1,4 +1,5 @@
 ; RUN: lli -extra-module %p/Inputs/weak-comdat-def.ll %s
+; XFAIL: target={{.*}}-darwin-{{.*}}

declare i32 @g()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443