[PATCH] D136163: Port PlaceSafepoints pass to the new pass manager

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

looks fine, mostly just some nits



================
Comment at: llvm/include/llvm/Transforms/Scalar/PlaceSafepoints.h:59
+
+namespace safepoints {}
+
----------------
is this necessary?


================
Comment at: llvm/include/llvm/Transforms/Scalar/PlaceSafepoints.h:73
+
+#endif // LLVM_TRANSFORMS_SCALAR_PLACESAFEPOINTS_H
----------------
nit: should have newline at end of file


================
Comment at: llvm/lib/Transforms/Scalar/PlaceSafepoints.cpp:101
 
+#pragma region Backedge Safepoints Pass(legacy only)
 namespace {
----------------
not sure what this is for, but it's not used elsewhere in LLVM so it probably shouldn't be added here


================
Comment at: llvm/test/Transforms/PlaceSafepoints/split-backedge.ll:2
 ;; A very basic test to make sure that splitting the backedge keeps working
-;; RUN: opt < %s -place-safepoints -spp-split-backedge=1 -S -enable-new-pm=0 | FileCheck %s
+;; RUN: opt < %s -place-safepoints -spp-split-backedge=1 -S | FileCheck %s
 
----------------
`-passes=place-safepoints`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136163/new/

https://reviews.llvm.org/D136163