[PATCH] D142791: [GlobalISel] Don't combine instructions with unknown type in hoist_logic_op_with_same_opcode_hands.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2753
   LLT YTy = MRI.getType(Y);
-  if (XTy != YTy)
+  if (!XTy.isValid() || !YTy.isValid() || XTy != YTy)
     return false;
----------------
Do you need to check for validity for both `XTy` and `YTy`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142791/new/

https://reviews.llvm.org/D142791