[PATCH] D142214: [MC] Do not copy MCInstrDescs. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 07:15:06 PST 2023


foad created this revision.
Herald added subscribers: kosarev, StephenFan, ThomasRaoux, kerbowa, hiraditya, jvesely, arsenm, MatzeB.
Herald added a project: All.
foad requested review of this revision.
Herald added a reviewer: zuban32.
Herald added a reviewer: mpaszkowski.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Avoid copying MCInstrDesc instances because a future patch will change
them to find their implicit operands and operand info array based on
their own "this" pointer, so it will only work for MCInstrDescs in the
TargetInsts table, not for a copy of an MCInstrDesc at a different
address.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142214

Files:
  llvm/include/llvm/MC/MCInstrDesc.h
  llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.h
  llvm/lib/Target/Lanai/LanaiDelaySlotFiller.cpp
  llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVInstPrinter.cpp
  llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVMCCodeEmitter.cpp
  llvm/unittests/CodeGen/LexicalScopesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142214.490832.patch
Type: text/x-patch
Size: 6597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230120/17d8ffdb/attachment.bin>


More information about the llvm-commits mailing list