[PATCH] D140848: [VPlan] Remove duplicated VPValue IDs (NFCI).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 07:19:36 PST 2023


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:769
          Def->getVPDefID() == VPRecipeBase::VPBranchOnMaskSC ||
          Def->getVPDefID() == VPRecipeBase::VPWidenMemoryInstructionSC;
 }
----------------
fhahn wrote:
> Ayal wrote:
> > nit: unrelated to this patch, but wonder if the above can be improved.
> I think it is not needed any longer now that `getDefinigRecipe` returns `VPRecipeBase` which already is a direct subclass of VPUser. I will remove it separately.
Done in 133f017479cc1f3c072986e43494b3820d928971


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140848/new/

https://reviews.llvm.org/D140848



More information about the llvm-commits mailing list