[PATCH] D141233: [OpenMP][GPU] Introduce the `ompx_dyn_cgroup_mem(<N>)` clause

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:04:09 PST 2023


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:23801
+  return new (Context) OMPXDynCGroupMemClause(
+      Size, HelperValStmt, CaptureRegion, StartLoc, LParenLoc, EndLoc);
+}
----------------
jdoerfert wrote:
> I used Size here not ValExpr. Fixed it locally.
Ah, yes, need to use the transformed expression, otherwise the declrefexpt won't be recognized as captured.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141233/new/

https://reviews.llvm.org/D141233



More information about the llvm-commits mailing list