[PATCH] D140479: [docs] Add tips on writing test constraints

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/docs/TestingGuide.rst:571-573
+``target={{.*(free|net)bsd.*}}`` and that would work. However, it would
+prevent a ``grep freebsd`` from finding this test. Better to use 
+``target={{.*(freebsd|netbsd).*}}`` in this case.
----------------
ldionne wrote:
> I might even suggest doing `target={{.+}}-freebsd-{{.+}} || target={{.+}}-netbsd-{{.+}}`. Characters are cheap and IMO this is clearer than trying to cram more logic into something smaller.
Oh, didn't see this comment before I pushed. Yeah... separating them entirely might be a better example.
I'm still inclined to use `freebsd{{.*}}` though, because there isn't guaranteed to be a `-suffix` and there might be a version number (I remember seeing `-freebsd9` years ago).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140479/new/

https://reviews.llvm.org/D140479