[PATCH] D140119: [PowerPC][GIsel] Materialize i64 constants.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 11:46:30 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:707
+      selectI64ImmDirect(I, MBB, MRI, Reg, Imm & 0xffffffff00000000);
+  if (!Res || !*Res)
+    return false;
----------------
I don't understand the point of the optional, just make it a bool


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140119/new/

https://reviews.llvm.org/D140119



More information about the llvm-commits mailing list