[PATCH] D138333: [CHR] Add a threshold for the code duplication

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:685
        PGOOpt->Action == PGOOptions::SampleUse))
     FPM.addPass(ControlHeightReductionPass());
 
----------------
I've had the thought in the past, shouldn't this go in the optimization pipeline (`buildModuleOptimizationPipeline`) rather than simplification pipeline (`buildModuleSimplificationPipeline`)? CHR definitely isn't a simplification. And that would make the check for ThinLTO phase go away since it'd only happen in the backend compile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138333/new/

https://reviews.llvm.org/D138333