[PATCH] D138529: [AVR] Optimize constant 32-bit shifts

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 06:09:27 PST 2022


aykevl marked an inline comment as done.
aykevl added a comment.

In D138529#3970417 <https://reviews.llvm.org/D138529#3970417>, @benshi001 wrote:

> Is it possible to break this large patch to smaller ones, in which the first one is just the skeleton (with only shiftAmount = 1 implemented as the basic situation) ? Then later ones implment each special shiftAmount  case .

I didn't split the patch because this way, there is no code size regression. But if you prefer I can split the patch in multiple patches and commit them all at the same time once accepted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138529/new/

https://reviews.llvm.org/D138529



More information about the llvm-commits mailing list