[PATCH] D139048: [AArch64] Make opcode switch in tryARM64PackedUnwind comprehensive.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 22:44:46 PST 2022


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/MC/MCWin64EH.cpp:1014
+    case Win64EH::UOP_ClearUnwoundToCall:
+      // These are special opcodes that aren't normally generated.
+      return false;
----------------
In addition to these, there's also `UOP_PushMachFrame` (which is shared with x86_64) which can be used on arm64, in the same way (only manually generated with custom assembly directives).

The fact that some opcodes are shared between x86_64, arm64 and arm is a bit messy - I guess it would be clearer if they would be entirely separate sets of opcodes without reuse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139048/new/

https://reviews.llvm.org/D139048



More information about the llvm-commits mailing list