[PATCH] D138334: Improve llvm-symbolizer search logic for symlink

[Pavel Labath via Phabricator via llvm-commits]

labath resigned from this revision.
labath added a comment.

yeah, the problem with symlinks is that one can never know whether a particular symlink (in particular context) was meant to be treated transparently or not. it gets even worse if you have multiple symlinks in the path or the resolution chain, as realpath will resolve all of them, which may not be what you wanted.

I'm not saying that this change is bad, but just as an FYI, it may be possible to fix your problem by replacing the lldb symlink with a shell script like `exec path/to/real/lldb "$@"`.

Resigning, as I don't feel comfortable approving changes in this part of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138334/new/

https://reviews.llvm.org/D138334