[PATCH] D137333: [AggressiveInstCombine] Avoid load merge/widen if stores are present b/w loads

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Sounds sensible to me in the short term. LGTM.

You could add a TODO comment about working on reenabling it with AA once we've worked through all the edgecases.



================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:732
 
   // Alias Analysis to check for store b/w the loads.
   LoadInst *Start = LI1, *End = LI2;
----------------
Perhaps add a TODO or reword this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137333/new/

https://reviews.llvm.org/D137333