[PATCH] D136442: [GISel] Add (fsub +-0.0, X) -> fneg combine

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 02:31:53 PDT 2022


Pierre-vh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fsub-fneg.mir:367
+...
+
----------------
arsenm wrote:
> Test for the undef vector element case
There's already a test "test_v4f32_negzero_undef_nofold". Do we want that to fold or not?
I guess so, since undef can be anything we can consider it to be identical to other other elements 

I updated it and added another one for poszero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136442/new/

https://reviews.llvm.org/D136442



More information about the llvm-commits mailing list