[PATCH] D136329: update_test_checks.py: allow use with custom tools

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added a comment.

Thanks, I also have a separate possible use case for this. Two minor inline comments.



================
Comment at: llvm/utils/update_test_checks.py:10
 Example usage:
 $ update_test_checks.py --opt=../bin/opt test/foo.ll
 
----------------
Maybe update the example to use the new tool argument, and mention above that opt-like
tools are also supported?


================
Comment at: llvm/utils/update_test_checks.py:122
+
     for prefixes, opt_args, preprocess_cmd in prefix_list:
+      common.debug('Extracted opt cmd: ' + tool_basename + ' ' + opt_args)
----------------
Maybe also rename `opt_args` to `tool_args`, and replace `opt` by `tool` in the debug message below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136329/new/

https://reviews.llvm.org/D136329