[PATCH] D135898: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 13:46:36 PDT 2022


sunfish added inline comments.


================
Comment at: lld/wasm/Driver.cpp:546
+  if (!config->memoryExport.hasValue() && !config->memoryImport.hasValue()) {
+    config->memoryExport = memoryName;
+  }
----------------
sbc100 wrote:
> Does this change the default linker behaviour to export the memory (when no flags are specified)?   I didn't realize that was the default behavior.
Yes, currently wasm-ld exports the memory by default. This patch preserves that default.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135898/new/

https://reviews.llvm.org/D135898



More information about the llvm-commits mailing list