[PATCH] D135753: [VP] Teach isVPBinaryOp to recognize vp.smin/smax/umin/umax/minnum/maxnum.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 04:58:06 PDT 2022


fakepaper56 added a comment.

In D135753#3864491 <https://reviews.llvm.org/D135753#3864491>, @eopXD wrote:

> Sorry that I am unclear to the context of `VP_BINARY_OP`, may elaborate on how adding `VP_BINARY_OP` helps the code generation?
> My trace stopped at `DAGCombiner.cpp` where `ISD::isVPBinaryOp() == true` is setting `return value type to undef.

As you mentioned, DAGCombiner make vp binary op with evl = 0 or false mask be undefined value. The improvement in test cases is caused that there is some vp operations with evl = 0 is transformed to undef value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135753/new/

https://reviews.llvm.org/D135753



More information about the llvm-commits mailing list