[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 01:18:31 PDT 2022


pengfei added inline comments.


================
Comment at: llvm/lib/IR/InlineAsm.cpp:72
+  // TODO: refine me, unify the delimiter or handle all cases.
+  if (AsmStrs.empty())
+    AsmStr.split(AsmStrs, "\0A", -1, false);
----------------
When split failed, the size of AsmStrs is 1 rather than empty.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914



More information about the llvm-commits mailing list