[PATCH] D133433: [AArch64-SVE]: lower all types of loads and stores of fixed-width vector

Hassnaa Hamdi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 03:07:21 PDT 2022


hassnaa-arm marked 2 inline comments as done.
hassnaa-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:69
+static cl::opt<bool>
+    ForceSVEWhenStreamingCompatible("force-sve-when-streaming-compatible",
+                                    cl::init(false), cl::Hidden);
----------------
sdesmalen wrote:
> Can you rename this variable to `ForceStreamingCompatibleSVE`? (likewise change the name of the flag to `-force-streaming-compatible-sve`)
> 
> The current name `ForceSVEWhenStreamingCompatible` suggests to use the full range of SVE instructions when in streaming-compatible mode, even the instructions that would be illegal in that mode, but that would be incorrect.
so there are some SVE instruction that are illegal in streaming mode ? like what ?
because I was checking only for NEON illegal instructions, not SVE illegal instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133433/new/

https://reviews.llvm.org/D133433



More information about the llvm-commits mailing list