[PATCH] D135402: [LLD] Enable --no-undefined-version by default.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 14:26:31 PDT 2022


MaskRay added a comment.

Thanks for catching this. The new default makes more sense and aligns with the other enabled-by-default diagnostic (`warn("attempt to reassign symbol` linking glibc libc.so is known to trigger some warnings).
I think the blast radius is very small since projects using exact patterns in a version script are rare. Default version symbols don't need patterns while non-default version symbols are rarely used.
When a pattern does not specify a symbol, it's very clear a user error.

Please update `lld/docs/ReleaseNotes.rst` and flip `lld/docs/ld.lld.1` to use `--undefined-version` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135402/new/

https://reviews.llvm.org/D135402



More information about the llvm-commits mailing list