[PATCH] D135067: [lit] RUN commands without stdin.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 09:13:50 PDT 2022


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

In D135067#3832848 <https://reviews.llvm.org/D135067#3832848>, @csigg wrote:

> In D135067#3830815 <https://reviews.llvm.org/D135067#3830815>, @probinson wrote:
>
>> So what would such a tool see?  Would it get an error trying to open stdin, or something else?
>
> A tool reading from stdin would get stdin, not an error and not an empty string (which it did before this change).

Ah.  I interpreted that to mean "it will hang waiting for input" and then I see the test expects lit to timeout the test.  That works.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135067/new/

https://reviews.llvm.org/D135067



More information about the llvm-commits mailing list