[PATCH] D134064: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y

Marc Auberer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 13:17:21 PDT 2022


marcauberer marked an inline comment as done.
marcauberer added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select_and_icmpeq.ll:33
+
+define i1 @select_and_icmpeq_i32_commuted3(i1 %x, i1 %y) {
+; CHECK-LABEL: @select_and_icmpeq_i32_commuted3(
----------------
spatel wrote:
> None of these commuted variants are logically different than the 1st test; they really just swap variable names. I don't think they're adding much value.
Removed the commuted variants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134064/new/

https://reviews.llvm.org/D134064



More information about the llvm-commits mailing list