[PATCH] D134851: [RISCV][WIP] Enable the local stack allocation pass for RISC-V.

Thu Sep 29 08:41:32 PDT 2022

StephenFan added a comment.

In D134851#3823338 <https://reviews.llvm.org/D134851#3823338>, @asb wrote:

> Hmm, I hadn't realised that this pass might allow us to avoid the need for an emergency spill slot. To answer your question about whether we should try to enable this - I think a definite yes, it should improve generated code slightly too.
>
> D98101 <https://reviews.llvm.org/D98101> also started to enable it, but the original author unfortunately ran out of time on addressing review feedback - it's probably worth reviewing that implementation and the review comments to see what might be relevant for this patch.

Glad to hear that this pass fixes some potential bugs. I pre-committed a patch D134884 <https://reviews.llvm.org/D134884> to add a local stack slot allocation test. I'm happy to continue maintaining that patch. Are you interested in taking a look at that patch? Or do you want to continue with your current patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134851/new/

https://reviews.llvm.org/D134851