[PATCH] D134794: [lld-macho] Do not error out on dead stripped duplicate symbols

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 10:33:53 PDT 2022


thakis added a comment.

> worth addressing the bad source code issues, there are also third-party libraries that we don't own that requires dead stripping in order for the link to succeed. While I think it's a valiant effort to engage with all those maintainers to fix this bug, it also seems infeasible to fix all of them. That said, would you be more inclined to this change if it were gated behind a flag instead of being the default behavior?

Do you have data how much harder these are to fix than (say) the text deduping failures? Like, how many known-broken libraries are we talking?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134794/new/

https://reviews.llvm.org/D134794



More information about the llvm-commits mailing list