[llvm] 096f1c4 - [InstSimplify] remove redundant predicate check; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 12:07:16 PDT 2022


Author: Sanjay Patel
Date: 2022-09-26T15:02:40-04:00
New Revision: 096f1c4db4e314b2c1d14d00bf8dd694ce561b7d

URL: https://github.com/llvm/llvm-project/commit/096f1c4db4e314b2c1d14d00bf8dd694ce561b7d
DIFF: https://github.com/llvm/llvm-project/commit/096f1c4db4e314b2c1d14d00bf8dd694ce561b7d.diff

LOG: [InstSimplify] remove redundant predicate check; NFC

It's still possible that there's a simpler way to specify
the conditions needed for this set of folds, but "getStrictPred"
converts >= to > for example, so there's no need to explicitly
check that.

Added: 
    

Modified: 
    llvm/lib/Analysis/InstructionSimplify.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/InstructionSimplify.cpp b/llvm/lib/Analysis/InstructionSimplify.cpp
index d36873f6aa556..49f61086a3956 100644
--- a/llvm/lib/Analysis/InstructionSimplify.cpp
+++ b/llvm/lib/Analysis/InstructionSimplify.cpp
@@ -4265,7 +4265,7 @@ static Value *simplifyCmpSelOfMaxMin(Value *CmpLHS, Value *CmpRHS,
     // (X <  Y) ? X : min(X, Y) --> min(X, Y)
     // (X <= Y) ? X : min(X, Y) --> min(X, Y)
     // (X == Y) ? X : min(X, Y) --> min(X, Y)
-    if (MMPred == Pred || MMPred == CmpInst::getStrictPredicate(Pred) ||
+    if (MMPred == CmpInst::getStrictPredicate(Pred) ||
         Pred == ICmpInst::ICMP_EQ)
       return MMI;
 
@@ -4276,7 +4276,7 @@ static Value *simplifyCmpSelOfMaxMin(Value *CmpLHS, Value *CmpRHS,
     // (X >= Y) ? X : min(X, Y) --> X
     // (X != Y) ? X : min(X, Y) --> X
     ICmpInst::Predicate InvPred = CmpInst::getInversePredicate(Pred);
-    if (MMPred == InvPred || MMPred == CmpInst::getStrictPredicate(InvPred) ||
+    if (MMPred == CmpInst::getStrictPredicate(InvPred) ||
         Pred == ICmpInst::ICMP_NE)
       return X;
   }


        


More information about the llvm-commits mailing list