[PATCH] D133731: [AMDGPU] Add Lower Bound to PipelineSolver

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:566
+      for (; I != E; I++) {
+        std::vector<std::pair<SUnit *, SUnit *>> AddedEdges;
+        int CandSGID = *I;
----------------
jsilvanus wrote:
> Maybe move the vector out of the loops to reduce allocations, and clear() here instead?
Why not move out of the other two loops as well?
Maybe with a comment that this is for performance only, and only needed in the most inner loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133731/new/

https://reviews.llvm.org/D133731