[PATCH] D132849: [llc] Use CPUStr instead of calling codegen::getMCPU(). NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 18:08:14 PDT 2022


MaskRay added a comment.

In D132849#3756719 <https://reviews.llvm.org/D132849#3756719>, @craig.topper wrote:

> In D132849#3756675 <https://reviews.llvm.org/D132849#3756675>, @MaskRay wrote:
>
>> Test?
>
> The only difference between getCPUStr() and getMCPU() is that getCPUStr() handles -mcpu=native. That doesn't matter for this case. I believe this is NFC as the title says.

This is fine. The motivation should be mentioned in the summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132849/new/

https://reviews.llvm.org/D132849



More information about the llvm-commits mailing list